Conversation
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
3 times, most recently
from
525c7f7 to
e94ab4b
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
e94ab4b to
0fa4f36
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
0fa4f36 to
cf14e42
Compare
daxpedda
left a comment
daxpedda
left a comment
There was a problem hiding this comment.
Missing a changelog entry, otherwise looks good.
I'm yet again surprised what we have to account for in a proc-macro ...
tests/discriminant.rs
Outdated
| #[repr(C)] | ||
| enum Test { | ||
| A = isize::MAX - 2, | ||
| A = (u32::MAX - 2) as isize, |
There was a problem hiding this comment.
Because while we can use isize as a type, we are only allowed to use i32 values in future versions of rust with repr(C), I could probably simplify this by just using the value of i32::MAX directly
There was a problem hiding this comment.
I think we should stick with isize until we get there, we also use isize internally, so we should test for that.
(on a side note: I'm doubtful this change will actually happen because it would break too much)
There was a problem hiding this comment.
Yeah, as this is only tests, we could just disable the lint
There was a problem hiding this comment.
Yeah, as this is only tests, we could just disable the lint
There was a problem hiding this comment.
Lint? Is there a lint warning against using isize here or whats going on?
(sorry for the late response)
There was a problem hiding this comment.
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
581cf1e to
5bf2cc0
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
00929b3 to
1382193
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
1382193 to
84d71e2
Compare
2 participants
closes #133